Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Dec 12, 2024

What do these changes do?

  • Introduce RabbitMqRpcClient in api server
  • Connect it to the webserver
  • Expose GET /v0/licensed-items

Related issue/s

How to test

cd services/api-server; make install-dev;
cd tests/unit
python -m pytest -k test_get_licensed_items

Dev-ops checklist

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Great work!
I would also like to follow up on some conventions with you before we add more functionality to the api-server :-)

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@bisgaard-itis bisgaard-itis changed the title ✨ Expose /licensed-items/page endpoint in api server ✨ Expose /licensed-items endpoint in api server Dec 12, 2024
@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) December 13, 2024 09:00
@bisgaard-itis bisgaard-itis merged commit e97f83b into ITISFoundation:master Dec 13, 2024
93 checks passed
@bisgaard-itis bisgaard-itis deleted the 6948-expose-licensing-endpoints-api-server branch December 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:apiserver api-server service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide functionality to list leased features and increase/decrease seat (API)

5 participants